Kyrluckechuck / TFT-Bot

Automate Teamfight Tactics (TFT) for token/mission farming. Updated for Set 8.5!

GNU Affero General Public License v3.0

50 stars 7 forks source link

Improve Multi-Screen Support #140

Closed akshualy closed 1 year ago

akshualy commented 1 year ago

All the screens

Description

Adds support for multiple screens by getting where the league game window is and screen-reading only the league game window.

Screen reader improvements:

Exclusively checks specified windows
Is able to calculate where images are and where to click based on where windows are on the screen
Drops imagesearch in favor of directly calling opencv2
Checks the league game window size and reports to the user if it does not match our requirements

Click helper improvements:

No longer does a second image read when trying to click an image
Supports clicking to a result from a screen reader call, as well as clicking to coordinates

General improvements:

Removed unused code in both of the above modules
Adds window title constants

Fixes #97

akshualy commented 1 year ago

It should be done from a logic and refactor standpoint. Now there's only some testing left to be done :) (And a re-review)

// EDIT I tested it successfully (after fixing a bug where I forgot to add the window position to the image search result) on the following window positions: (1920, 10, 3840, 1090), (-1920, 0, 0, 1080) (Yeah, I was surprised that pixels left of the primary monitor are negative as well), (0, 0, 1920, 1080).

Also updated the PR description with TL;DR bullet points for convenience.