search

Kyrluckechuck / TFT-Bot

Automate Teamfight Tactics (TFT) for token/mission farming. Updated for Set 8.5!
GNU Affero General Public License v3.0
50 stars 7 forks source link

QOL improvements #161

Closed akshualy closed 1 year ago

akshualy commented 1 year ago

Cleaning

Description

This PR holds some clean-up QOL improvements which were a few lines of code of change.

  1. The bot no longer levels after level 8. I've never seen it reach level 9, so this should save some gold.
  2. The button that appears if you win a game is now recognized as a valid "Exit Now" button. The bot wouldn't break on victory, but if it does reach first place, it waits the full 25 seconds before continuing.
  3. We now log the storage path, closing #157 a. I could not figure out a better way to require UAC elevation, so we'll just have to keep asking users to run as admin. At least now this issue is also logged in the console.
  4. Refactors the resource_path method to a) get the _MEIPASS variable in a more "gentle" manner and b) remove it entirely, since it didn't do anything anymore.

Notes

Had to move out a few methods in main() since we started having too many, but I think that's a good change.

akshualy commented 1 year ago

Would it make sense to also add the starting of League (and any other sub-programs) as non-administrator to this?

It is better to run League as admin, according to their official support page. I don't have a strong opinion on adding it, just wanted to bring this up for discussion first before doing so.

I genuinely wish that handling UAC/permissions would be more convenient, but it is what it is.