Kyromyr / D2Stats

59 stars 33 forks source link

Add support for multiple notifier rules selected using a combo box #19

Closed hristoforyordanov92 closed 2 years ago

hristoforyordanov92 commented 2 years ago

Hello :) Since I've started playing some Diablo 2 recently and had to use this awesome tool, I also needed to change my Notifier Rules multiple times because I've been playing a few characters and also because I have multiple rule sets based on my progression in the game. So I have decided to try and implement an easy way to save and switch between multiple Notifier Rules.

How does it work? When you open the tool, it will check if you have any Notifier Rules files. If not, it will create one for you in the NotifierRules folder. It has backwards compatibility - if you only replace your D2Stats.exe file (or if you backup your old D2Stats.exe.ini), it will create a new notifier rules file with your old notifier rules notifier_01

Of course you can create more of those rules files with the New button notifier_02

Or Rename the currently existing files notifier_03

Or if you're not happy with an old Notifier Rules file, you can completely Delete it notifier_04

Programmer notes: I have never heard of AutoIt up until now (I'm a C# dev), so my code may not be up to your standards. I tried keeping up with your style, but I might have missed something or the code might not be as optimal, due to lack of AutoIt experience :)

The changes on line 1050 and 1054 were needed because whenever I had a file named "Default" and a comparison was made, this statement

if ("Default" == Default)

would evaluate to true... I am not 100% sure if my change is the best fix for this problem and I haven't tested it much for all other options, so this might need some extra attention.

I think the tool's main window could benefit from an enlargement, especially when it comes to its height, but I haven't done it in this change.

I would love to get some feedback about this feature. Thanks in advance!