KyrosKrane / AnnoyingPopupRemover

World of Warcraft addon to remove some annoying popups in the game
MIT License
4 stars 1 forks source link

Skip confirmation popup for using XP item on follower #41

Closed teelolws closed 4 months ago

teelolws commented 6 months ago

This is the code I quickly whipped up that accomplishes it, though I'm sure you have a more secure method:

hooksecurefunc("StaticPopup_Show", function(upgradeType) if upgradeType == "CONFIRM_FOLLOWER_UPGRADE" then StaticPopupDialogs["CONFIRM_FOLLOWER_UPGRADE"].OnAccept(StaticPopup1) StaticPopup_Hide("CONFIRM_FOLLOWER_UPGRADE") end end)

KyrosKrane commented 6 months ago

Thanks for the idea! I'll research this and see how I can add it. I know that there's all kinds of weird UI errors in this area from personal experience (the UI will frequently block me from using follower upgrade items for some reason), so I'll want to make sure this doesn't make that worse.

teelolws commented 6 months ago

I've been using that script for a couple weeks now, haven't encountered anything blocked because of it.

KyrosKrane commented 4 months ago

Working on this in the Followers branch.

KyrosKrane commented 4 months ago

@Machou If you're able, could you please provide the French translation for these lines?

-- followers
L["followers_name"] = "Equip or upgrade followers with items"
L["followers_config"] = "Hide the confirmation pop-up when using items on followers at mission tables"
L["followers_hidden"] = "Confirmation pop-up when upgrading " .. APR.Utilities.CHAT_GREEN .. "followers" .. FONT_COLOR_CODE_CLOSE .. " at mission tables will be " .. APR.Utilities.CHAT_GREEN .. "hidden" .. FONT_COLOR_CODE_CLOSE .. "."
L["followers_shown"] = "Confirmation pop-up when upgrading " .. APR.Utilities.CHAT_RED .. "followers" .. FONT_COLOR_CODE_CLOSE .. " at mission tables will be " .. APR.Utilities.CHAT_RED .. "shown" .. FONT_COLOR_CODE_CLOSE .. "."
Machou commented 4 months ago

@KyrosKrane Follower is for Fief (WoD), BfA or Shadowlands ? who is ? :p

KyrosKrane commented 4 months ago

@KyrosKrane Follower is for Fief (WoD), BfA or Shadowlands ? who is ? :p

All of them. :) All the mission tables. Although you reminded me I need to test it with the Shadowlands table too.

KyrosKrane commented 4 months ago

To be clear, so far I've tested the following:

WoD follower item level upgrades (armor/weapon) WoD follower abilities and traits reroll WoD follower abilities reroll WoD follower traits reroll WoD follower single-trait replacement

WoD shipyard equipment - fresh WoD shipyard equipment - replacement

Legion class hall follower equipment - fresh Legion class hall follower equipment - replacement

BFA mission table follower equipment - fresh BFA mission table follower equipment - replacement

SL covenant table followers don't use equipment, so nothing to test.

teelolws commented 4 months ago

SL has the items that give the followers XP

Machou commented 4 months ago

@KyrosKrane i think this translate is fine :

-- followers
L["followers_name"] = "Équipez ou améliorez vos sujets avec des objets"
L["followers_config"] = "Masquer la fenêtre de confirmation lorsque vous équipez ou améliorez vos sujets avec des objets dans les différentes tables de commandement"
L["followers_hidden"] = "La fenêtre de confirmation lorsque vous équipez ou améliorez vos " .. APR.Utilities.CHAT_GREEN .. "sujets" .. FONT_COLOR_CODE_CLOSE .. " dans les différentes tables de commandement sera " .. APR.Utilities.CHAT_GREEN .. "masquée" .. FONT_COLOR_CODE_CLOSE .. "."
L["followers_shown"] = "La fenêtre de confirmation lorsque vous équipez ou améliorez vos " .. APR.Utilities.CHAT_RED .. "sujets" .. FONT_COLOR_CODE_CLOSE .. " dans les différentes tables de commandement sera " .. APR.Utilities.CHAT_RED .. "affichée" .. FONT_COLOR_CODE_CLOSE .. "."
KyrosKrane commented 4 months ago

Got them, thank you!

I'll go test in covenant tables later today, then put out a beta version.

KyrosKrane commented 4 months ago

SL has the items that give the followers XP

Thanks for the reminder! Got that added in and tested now.

OK, everything should be set up in v20.0.0-beta, which should be packaging shortly. In the next day or two I'll do one last round of testing, update the documentation, and release it. Thanks all for the help and feedback!

KyrosKrane commented 4 months ago

v20 should be packaging momentarily. Thanks all!