search

Kyslik / FEIStyle

Upgraded FEIStyle
MIT License
22 stars 23 forks source link

Change Study Field. Remove Study Field Number. Update Release Version. #26

Closed matusjokay closed 4 years ago

matusjokay commented 4 years ago

1) Change Study Field 'Applied Informatics' to 'Informatics'. 2) Remove Study Field Number. 3) Update Release Version

matusjokay commented 4 years ago

Any reason why we commenting stuff out instead of removing? monocle_face

LGTM (did not compile, looks like non breaking change)

Yes. There is minimal probability of using Study Field Number in future. But, for now, this field is not required by University. Now Study Field Number varies from one type of study to another one: PhD ext has 104370, PhD int has 104372, Master 16607 and Bachelor 16605. So, if the filed will be required, major changes will be made regardless Study Field Number. Comment lines are good start points to do it ;)

matusjokay commented 4 years ago

students are waiting for this PR... 2020-05-15 is deadline for master students ;)

Kyslik commented 4 years ago

Hmmm, can't you merge yourself? You are collaborator.