search

Kyslik / column-sortable

Package for handling column sorting in Laravel 5/6/7/8
MIT License
644 stars 105 forks source link

Allow for custom URL #156

Closed Healyhatman closed 4 years ago

Healyhatman commented 4 years ago

Adds a 5th parameter allowing for a custom URL to be used

Healyhatman commented 4 years ago

@Kyslik is there anything you would want me to change or add to get this merged in?

Kyslik commented 4 years ago

Are you still needing this change? I am not happy adding more things to the parameters :(.

Healyhatman commented 4 years ago

I still need this change, yes please. If you can think of a way to do it without the additional optional parameter I'm more than happy to help. You could have that last parameter take an array if you like, so you could have (thing, thing2, thing3, thing4, ['url' => route('my.route'), 'some_other_parameter_someone_thinks_of_later' => $value])

Kyslik commented 4 years ago

Would you be able to change also readme.md? Assume adding the 5th parameter.

Healyhatman commented 4 years ago

@Kyslik Not that great at this github stuff, please have a look at my patch 2 pull request. I removed the 5th parameter, and put it in as a 'href' attribute on the 4th (anchorAtrributes) parameter instead. Which I should've done the first time, sorry