search

Kyslik / column-sortable

Package for handling column sorting in Laravel 5/6/7/8
MIT License
641 stars 105 forks source link

Check if `sort` of request exists in array/db #182

Closed denisdulici closed 3 years ago

denisdulici commented 3 years ago

The user can manipulate the sort variable by entering a non-sortable value and in that case, the $defaultParameters should be applied.

denisdulici commented 3 years ago

@Kyslik @Healyhatman Can you please consider this PR?

Healyhatman commented 3 years ago

It's completely silent though - if you put in a non-sortable column there's nothing to tell you why it's not sorting the way you expect it to

denisdulici commented 3 years ago

Yes, but that's out of the purpose of this package, right?

denisdulici commented 3 years ago

@Kyslik @Healyhatman Can you please kindly let me know if you're just not going to merge this PR? It's breaking our software and we'll have to implement another solution otherwise.

Kyslik commented 3 years ago

@Kyslik @Healyhatman Can you please kindly let me know if you're just not going to merge this PR? It's breaking our software and we'll have to implement another solution otherwise.

Hey; I am looking for contributors. @Healyhatman WDYT?

Kyslik commented 3 years ago

@Healyhatman has a point if it breaks the behavior it can't go in; only in next major version. Please also include readme changes & tests.

denisdulici commented 3 years ago

It seems you're not aware that this is a bug fix but anyway, it's a no reply to my question. Thanks, and good luck!

Healyhatman commented 3 years ago

After testing I understand now the problem you're having, but I won't be merging this pull request because it doesn't work with relationships. E.g. if you are sorting WorkerTimesheets by worker.first_name, your change won't work.