Closed denisdulici closed 3 years ago
@Kyslik @Healyhatman Can you please consider this PR?
It's completely silent though - if you put in a non-sortable column there's nothing to tell you why it's not sorting the way you expect it to
Yes, but that's out of the purpose of this package, right?
@Kyslik @Healyhatman Can you please kindly let me know if you're just not going to merge this PR? It's breaking our software and we'll have to implement another solution otherwise.
@Kyslik @Healyhatman Can you please kindly let me know if you're just not going to merge this PR? It's breaking our software and we'll have to implement another solution otherwise.
Hey; I am looking for contributors. @Healyhatman WDYT?
@Healyhatman has a point if it breaks the behavior it can't go in; only in next major version. Please also include readme changes & tests.
It seems you're not aware that this is a bug fix but anyway, it's a no reply to my question. Thanks, and good luck!
After testing I understand now the problem you're having, but I won't be merging this pull request because it doesn't work with relationships. E.g. if you are sorting WorkerTimesheets by worker.first_name, your change won't work.
The user can manipulate the
sort
variable by entering a non-sortable value and in that case, the$defaultParameters
should be applied.