Kyslik / column-sortable

Package for handling column sorting in Laravel 5/6/7/8
MIT License
641 stars 105 forks source link

Laravel 9.x Compatibility #191

Closed laravel-shift closed 2 years ago

laravel-shift commented 2 years ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 2 years ago

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

laravel-shift commented 2 years ago

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

laravel-shift commented 2 years ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/column-sortable.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "kyslik/column-sortable": "dev-l9-compatibility",
    }
}

Finally, run: composer update

benjivm commented 2 years ago

Will this be merged?

crlcu commented 2 years ago

I'm also watching this.

crlcu commented 2 years ago

Can this pr be merged and tagged ?

pixelcreation-beheer commented 2 years ago

I would also appreciate this being merged and tagged asap.

I can confirm it works on my end with when using Shift's Laravel 9 branch.

aglipanci commented 2 years ago

@Kyslik can you please find some time to merge this?

bhojkamal commented 2 years ago

Any news for Laravel 9 compatibility?

aglipanci commented 2 years ago

@bhojkamal it's already merged. You can use version 6.4.

bhojkamal commented 2 years ago

@bhojkamal it's already merged. You can use version 6.4.

Thanks @aglipanci It is good to update on repo and .md info as well. Still there is Laravel 5.5-8.