search

Kyslik / laravel-filterable

Laravel 5/6/7 package to handle filtering by query-string
MIT License
116 stars 34 forks source link

Please make filters() method protected #13

Closed rtconner closed 5 years ago

rtconner commented 5 years ago

Can you please make filters method protected. I would like to override it in my code.

... either that or provide another way for me to modify how this library reads the request object. Currently it forces use of $this->request->only

Kyslik commented 5 years ago

@rtconner yea, will look in to it.

Kyslik commented 5 years ago

@rtconner I can not really change the visibility of filters() method; tests do fail if it's done. I think you can just override applyFilters() and not use $this->filters() at all.

Can you elaborate on $this->request->only, what else would you use in this scenario? It needs to check each and every field one by one. Every suggestion counts.