search

Kyslik / laravel-filterable

Laravel 5/6/7 package to handle filtering by query-string
MIT License
116 stars 34 forks source link

Compatibility with Laravel 6 #14

Open trollfalgar opened 5 years ago

trollfalgar commented 5 years ago

Can you update the package to be compatible with Laravel 6?

Kyslik commented 5 years ago

I did not think anyone uses this package; I will see what I can do; definitely will drop Support for L5.* and just go straight for L6.

I'd appreciate a PR if possible though!

lachlanhickey commented 5 years ago

This app is literally the back bone of my search functioanlity across many of my applications.. It's certaintly in use!

trollfalgar commented 5 years ago

I did not think anyone uses this package; I will see what I can do; definitely will drop Support for L5.* and just go straight for L6.

I'd appreciate a PR if possible though!

This package is really good. Thanks!

rtconner commented 5 years ago

Yes please upgrade to laravel 6. Also I love this package a lot, I use it in all my projects.

I really don't see why this would not work in both 6.0 and 5.8. I think you would just need to update the composer file and that is all.

Ekion-1 commented 5 years ago

This package absolutely is being used. L6 support would be hugely appreciated!

Kyslik commented 5 years ago

Yes please upgrade to laravel 6. Also I love this package a lot, I use it in all my projects.

I really don't see why this would not work in both 6.0 and 5.8. I think you would just need to update the composer file and that is all.

I noticed failing pipeline in Travis for this package; so I need to investigate.

I will take care of this package soon; to be honest I was hoping for some PRs.

Ekion-1 commented 5 years ago

I've forked this (https://github.com/AlexGodbehere/laravel-filterable) and updated the dependencies, but the tests are failing on Call to undefined function Kyslik\LaravelFilterable\Generic\starts_with(). I'll take a look at this properly when I get time.

Ekion-1 commented 5 years ago

Created https://github.com/Kyslik/laravel-filterable/pull/16. Travis is passing but i've disabled one troublesome test. This will need fixing before we merge.

Ekion-1 commented 5 years ago

I noticed failing pipeline in Travis for this package; so I need to investigate.

Support for PHP7.1 was dropped in Laravel 6. This looks like one of the problems.

Kyslik commented 5 years ago

Hey guys, I've merged @AlexGodbehere's PR to L6 branch so for now, you can use dev-L6 as dependency in your composer file and try it out.

composer require kyslik/laravel-filterable dev-L6

or 

{
    "require": {
        "kyslik/laravel-filterable": "dev-L6"
    }
}

I will update you once I will release a real version.

qindj commented 5 years ago

This app is literally the back bone of my search functioanlity across many of my applications.. It's certaintly in use!

+1

phylaxis commented 2 years ago

Hey, I'm having issues with using this branch after upgrading to Laravel 6. I'm getting this error:

Symfony \ Component \ HttpKernel \ Exception \ HttpException
Macro '->hasAnyFilter' requires a parameter of a \Kyslik\LaravelFilterable\FilterContract.

I'm reviewing all the docs and it seems as if I have everything implemented correctly. Does anyone here have any thoughts on what I might be doing wrong? Thanks in advance for any help.

phylaxis commented 2 years ago

Just want to check back in here one more time before I give up and move on. Does anyone know what might be causing this error? I assume this project has been abandoned? If so, what are people using as a replacement / alternative?

trollfalgar commented 2 years ago

Just want to check back in here one more time before I give up and move on. Does anyone know what might be causing this error? I assume this project has been abandoned? If so, what are people using as a replacement / alternative?

The creator abandoned the package. I recommend search for alternatives. I refactored my application to use only model scopes, for exemple.