Closed Ekion-1 closed 5 years ago
@AlexGodbehere Hey! Thank you for the PR; nice. I've found what is going on Carbon does not throw up if we feed it with invalid data.
➜ blog art tinker
Psy Shell v0.9.9 (PHP 7.3.9 — cli) by Justin Hileman
>>> $a = new Illuminate\Support\Carbon()
=> Illuminate\Support\Carbon @1568326191 {#2994
date: 2019-09-12 22:09:51.628899 UTC (+00:00),
}
>>> $a->timestamp('ab')
=> Illuminate\Support\Carbon @0 {#2994
date: 1970-01-01 00:00:00.0 UTC (+00:00),
}
Previously it threw \Exception
so I guess I can remove the test and not catch the exception. I will figure this out :).
I've updated the functions that were throwing errors in the Travis tests to use the Laravel helper facades. For some reason, I'm unable to run the tests on my local machine so debugging the
test_template_timestamp_throws_up
test is quite difficult. I've disabled it here to see if there was any other issues in the build, so this will need fixing before merging.