Kyubyong / g2pC

g2pC: A Context-aware Grapheme-to-Phoneme Conversion module for Chinese
Apache License 2.0
235 stars 30 forks source link

Suggest to loosen the dependency on pkuseg #8

Open Agnes-U opened 1 year ago

Agnes-U commented 1 year ago

Dear developers,

Your project g2pC requires "pkuseg==0.0.22" in its dependency. After analyzing the source code, we found that the following versions of pkuseg can also be suitable without affecting your project, i.e., pkuseg 0.0.21. Therefore, we suggest to loosen the dependency on pkuseg from "pkuseg==0.0.22" to "pkuseg>=0.0.21,<=0.0.22" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.

May I pull a request to further loosen the dependency on pkuseg?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



Details:

Your project (commit id: 869f36f0b1c23a48e90f7191af575b71976ce5bb) directly uses 1 APIs from package pkuseg.

pkuseg.__init__.pkuseg.__init__

Beginning fromwhich, 35 functions are then indirectly called, including 12 pkuseg's internal APIs and 23 outsider APIs as follows:

[/Kyubyong/g2pC]
+--pkuseg.__init__.pkuseg.__init__

Since all these functions have not been changed between any version for package "pkuseg" from [0.0.21] and 0.0.22. Therefore, we believe it is safe to loosen the corresponding dependency.