search

KyujinHan / Sakura-SOLAR-DPO

Sakura-SOLAR-DPO: Merge, SFT, and DPO
115 stars 7 forks source link

Typo #1

Closed mlabonne closed 10 months ago

mlabonne commented 10 months ago

Hi, congrats and thanks a lot for sharing your code and hyperparameters!

I noticed a small typo in the code (https://github.com/KyujinHan/Sakura-SOLAR-DPO/blob/4d93e18904c82bc67c3fc24bf217de4159d602dd/DPO.py#L167): "Assitant" instead of "Assistant". It doesn't seem to be very important considering the performance of the model, but maybe something to fix for the next run.

KyujinHan commented 10 months ago

Thank you for your comment!

I fixed the typo right away! Thank you for your interest in the code :)