search

Kyupii / CheToolbox

A personal project which packages common Chemical Engineering Calcs & Physical properties libraries.
GNU General Public License v3.0
2 stars 0 forks source link

Validate bubble_point function #19

Closed zship96 closed 8 months ago

zship96 commented 8 months ago

Validate bubble_point in separations.py is correct against examples. Provide proof/code used to test.

zship96 commented 8 months ago

On first pass, this is what I have determined. Major Issues: Fails when given an example problem. There may be an issue with the way we are using functions from common.py

See test setup and return below: Chetoolbox bubble point 1

Minor Issues: Docstrings and function arguments may benefit from edits, hard to read when using.

Unless it would harm some of the functionality of this, I'd like to suggest a re-write for this function that simplifies it and takes advantage of the fact that we have scipy dependency and Antoine's equation is being used. We shouldn't necessarily need to use a linear estimation and error functions from common.

Kyupii commented 8 months ago

re-arranged variable assignment in common.py

bubble_point is working now.