search

Kyza / Khub

A repo for all my released BetterDiscord plugins and themes.
https://khub.kyza.net/
Other
31 stars 29 forks source link

[CustomDiscordIcon] Not working on Discord Canary #20

Open fixator10 opened 5 years ago

fixator10 commented 5 years ago

What plugin does the bug occur in? CustomDiscordIcon

What version is the plugin? 1.1.3 (7f9c29120dcc4acf4e5cdb50fdf9d44c84e7ac4b)

Describe the bug. Not working on Canary Discord build

Give steps to reproduce the bug.

  1. Install Canary
  2. Install BBD
  3. Add CustomDiscordIcon plugin
  4. Load it
  5. Check console for errors

Add attachments or screenshots to help me reproduce the bug. Custom icon

Uncaught Error: Could not call remote method 'setIcon'. Check that the method signature is correct. Underlying error: Error processing argument at index 0, conversion failure from https://tsunemori.is-a-good-waifu.com/9cLh1hZ.jpg

DM/Guild icon

Uncaught Error: Could not call remote method 'setIcon'. Check that the method signature is correct. Underlying error: Error processing argument at index 0, conversion failure from C:\Users\Fixator10\AppData\Roaming\BetterDiscord\plugins\icon.png

DM/Guild icon on fresh VM install

Uncaught Error: Could not call remote method 'setIcon'. Check that the method signature is correct. Underlying error: Error processing argument at index 0, conversion failure from
issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.88. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Kyza commented 5 years ago

https://tsunemori.is-a-good-waifu.com/9cLh1hZ.jpg

URLs don't work, you have to use a local file path.

What operating system are you on?

I see now that you're on Windows. When I rewrite CustomDiscordIcon hopefully all the bugs will be fixed with the icon not appearing in certain situations.

fixator10 commented 5 years ago

Well... It's kinda working with direct path to file, but switching guild for first time after changing of settings throws error.

Also, it works only in Alt+Tab/Taskbar preview. In taskbar list it doesn't changes

img

Windows version: Windows-10-10.0.18362-SP0 Canary build: [BUILD INFO] Release Channel: canary, Build Number: 46198, Version Hash: c2687e7042c04a39603b0c99c1308a5f0b2be92a

Kyza commented 5 years ago

I see your problem.

For some odd reason you need to set your taskbar icons to always expand.

I'll be doing a full plugin rewrite soon. So hopefully I'll be able to make it much better internally as well as less buggy.