L-A-Marchetti / BOMulus

📑 BOMulus is a Go application with a GTK-based GUI that allows users to compare and analyze BOM files. It provides version control functionality to identify added, deleted, and updated lines between two BOMs.
11 stars 1 forks source link

Price calculation fixes #70

Closed Octavelscx closed 1 month ago

Octavelscx commented 1 month ago

Updated the pricing calculations to display unit prices and price differences per unit for various quantities, using the new QuantityPrice() function instead of MinMaxPrice(). Also, renamed variables and functions for clarity and consistency, such as changing minMaxPriceLabelText to priceLabelText.

Octavelscx commented 1 month ago

When changing the comparisons files I have sometimes :

(BOMulus.exe:10936): GLib-GObject-CRITICAL **: 14:07:10.830: g_object_set_is_valid_property: object class 'GtkBox' has no property named 'hadjustment'

(BOMulus.exe:10936): Gtk-CRITICAL **: 14:07:10.831: gtk_bin_remove: assertion 'priv->child == child' failed

(BOMulus.exe:10936): Gtk-CRITICAL **: 14:07:19.795: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed

(BOMulus.exe:10936): Gtk-CRITICAL **: 14:07:19.795: gtk_widget_translate_coordinates: assertion 'GTK_IS_WIDGET (dest_widget)' failed

(BOMulus.exe:10936): Gtk-CRITICAL **: 14:07:19.796: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed

I think in compare_view cleaning the content of the vbox by removing its children rather than deleting and recreating the vbox itself should avoid theses errors