L-Acoustics / avdecc

A set of open source libraries for controlling AVB entities using the AVDECC (IEEE 1722.1) protocol compliant to Avnu Milan Specifications
GNU Lesser General Public License v3.0
89 stars 22 forks source link

Add support for TIMING descriptor, 1722.1-2021 clause 7.2.34 #116

Closed andrew-elder closed 1 year ago

christophe-calmejane commented 2 years ago

Thanks Andrew. I was just (yesterday) about to enter this ticket, looking at the correct way to link CLOCK_SOURCE descriptor to a TIMING / PTP_INSTANCE one and figured out the clock_source_type field should be set to EXTERNAL (to be confirmed by 1722.1, because it's not clear in the latest specification as it specifically says via a Jack).

Do you want to contribute this or willing to wait a bit (was planing on doing it in the coming weeks)?

andrew-elder commented 2 years ago

Hi Chris, It sounds like we should wait and see what 1722.1 says/confirms? I'm not it too much of a hurry - just need to be able to select the clock source via 1722.1 (and maybe Hive).

christophe-calmejane commented 2 years ago

Yes, probably best to be sure of the correct way to do things. I already got an unofficial confirmation of the way to do it, but the question will be asked on the 1722.1 reflector pretty soon. Although it doesn't prevent the implementation of the descriptors, just how an entity should define its fields correctly.