Build fails

[andrew-elder]

I'm seeing compile errors...

$ gcc --version
gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

/avdecc/examples/src/utils.cpp: In function ‘void outputText(const string&)’:
/avdecc/examples/src/utils.cpp:95:24: error: format not a string literal and no format arguments [-Werror=format-security]
   95 |                 wprintw(s_Window, str.c_str());

using branch dev

$ git log --oneline
4b43887 (HEAD -> dev, origin/dev) Fixed rare crash during entity enumeration

I can add -Werror=format-security to the cmake file is that is the recommended fix.

[christophe-calmejane]

Thanks I'll take a look tomorrow. Unfortunately I didn't add the dockerfiles to this repo, easier to get a stable dev env 😜 Will fix this as well!

[christophe-calmejane]

Hum that's weird, I don't have any issue when building from the docker env, same compiler version (gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0), no warning whatsoever. I guess the simplest solution would be to fix the actual error, can you try on your system to insert "%s" as second parameter to the wprintw call?

[andrew-elder]

@christophe-calmejane - that suggestion worked, thanks. Do you want me to make a branch and merge request, or do you just want to make the change?

[christophe-calmejane]

Please do, it's always good to have many contributors to a projet ;)

[andrew-elder]

@christophe-calmejane - I seem to have a permissions issue

git push origin fix-build 
ERROR: Permission to L-Acoustics/avdecc.git denied to andrew-elder.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

[christophe-calmejane]

Yes, actually on github the correct procedure is to make a fork on your own github space, and make a PR from there.

[andrew-elder]

PR created.

[christophe-calmejane]

Thanks