L-Acoustics / avdecc

A set of open source libraries for controlling AVB entities using the AVDECC (IEEE 1722.1) protocol compliant to Avnu Milan Specifications
GNU Lesser General Public License v3.0
90 stars 21 forks source link

Improve Unsol Loss detection #126

Closed christophe-calmejane closed 1 year ago

christophe-calmejane commented 1 year ago

The algorithm may cause some unexpected behaviors

christophe-calmejane commented 1 year ago

The controller always expect 0 as first unsol for Milan device (as the spec says). The issue is that if the controller restarts (quickly) without properly deregistering first, the device cannot detect the controller restarted (even though it's sending a new REGISTER_UNSOL, because the Milan spec doesn't specify the counter should, or not, reset), and will continue sending unsol using its current sequence.