L-K-Chng / pe

0 stars 0 forks source link

Exercise data file allows for invalid data to be input #14

Open L-K-Chng opened 1 year ago

L-K-Chng commented 1 year ago

Upon addition of a negative value to exercise data, the file still runs normally and the negative value is pushed back into the program.

image.png

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

"Calories Lost" can be reported as negative values

Describe the bug

The calories lost field can be a negative value

To Reproduce

  1. Input the exercise command
  2. Input a negative value in the /calories field
  3. Input the track all command

Expected behavior

The calories consumed should increase by the negative value input earlier

Screenshots/Video

image.png


[original: nus-cs2113-AY2223S2/pe-interim#375] [original labels: severity.VeryLow type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This should not be an issue of very low severity since it is not purely cosmetic. Users will be inconvenienced if they are not able to accurately calculate their total calories, and this program would not allow the user to keep track of their net calorie gain on a daily basis, as seen from your group's Value Proposition. ![image.png](https://raw.githubusercontent.com/L-K-Chng/pe/main/files/93ecc653-a3a2-4900-84e9-9571bb6438b2.png)