L-K-Chng / pe

0 stars 0 forks source link

Allowance of invalid dates for program #7

Open L-K-Chng opened 1 year ago

L-K-Chng commented 1 year ago

While the year 1800 is a valid year, the program allows for such a date for the user to log their meal details. Should they be born in that year, the user is likely to have passed on already and should not have such details logged into the program

image.png

nus-pe-script commented 1 year ago

Team's Response

We disagree. 3/12/1800 did happen and is a valid date. We only threw an exception for an actual invalid date, such as 31/2/1800.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Yes it is true that 3/12/1800 is a valid date, however, is it truly a relevant date? It definitely is not, because anyone with diet records back in the year 1800 has likely ceased to exist. We know that realistically, users should not be able to add dates from as far back as the year 1700/1800. What is the point of being able to set dates in such a program if I am able to add improper dates as and when I want?


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This is not an issue that is purely cosmetic, since it has to do with the program allowing for impossible dates such as the one shown (3/12/1800), which is clear evidence of it being a functionality bug, and also why the severity should be low instead of very low.