L-Leite / cso2-master-server

A master server for CSO2
MIT License
155 stars 62 forks source link

Server crashes while create a new room #6

Closed GEEKiDoS closed 5 years ago

GEEKiDoS commented 5 years ago
packet from c9e5ea62-9f96-4d80-bf4f-a3f71d13d470 seq: 8 length: 48
C:\Users\Administrator\cso2-master-server\dist\packets\in\packet.js:112
            throw new Error('Data buffer is too small');
            ^

Error: Data buffer is too small
    at InRoomPacket.readUInt32 (C:\Users\Administrator\cso2-master-server\dist\p
ackets\in\packet.js:112:19)
    at new InRoomNewRequest (C:\Users\Administrator\cso2-master-server\dist\pack
ets\in\room\fullrequest.js:25:31)
    at InRoomPacket.parse (C:\Users\Administrator\cso2-master-server\dist\packet
s\in\room.js:74:35)
    at new InPacketBase (C:\Users\Administrator\cso2-master-server\dist\packets\
in\packet.js:21:14)
    at new InRoomPacket (C:\Users\Administrator\cso2-master-server\dist\packets\
in\room.js:23:1)
    at ChannelManager.onRoomRequest (C:\Users\Administrator\cso2-master-server\d
ist\channel\channelmanager.js:74:27)
    at ServerInstance.onIncomingPacket (C:\Users\Administrator\cso2-master-serve
r\dist\serverinstance.js:186:38)
    at ServerInstance.onSocketData (C:\Users\Administrator\cso2-master-server\di
st\serverinstance.js:160:14)
    at Socket.newSocket.on (C:\Users\Administrator\cso2-master-server\dist\serve
rinstance.js:85:18)
    at Socket.emit (events.js:182:13)
GEEKiDoS commented 5 years ago

But it worked sometimes....

L-Leite commented 5 years ago

Can you tell me the steps you took to crash the server?

GEEKiDoS commented 5 years ago

Can you tell me the steps you took to crash the server?

First I start server with npm run-script start -- -i 0.0.0.0 on my server Then start client with .\launcher.exe -lang schinese -masterip <my server ip> -masterport 30001 after that, I just followed

Getting ingame

Section in the README.md of client repo, after

Create your own room by pressing 방만들기 (room) (example) then choosing game mode (example);

the server crashes with "Data buffer is too small"

GEEKiDoS commented 5 years ago

qq 20181118122459 It worked sometimes, IDK what's wrong

L-Leite commented 5 years ago

which game mode did you select?

L-Leite commented 5 years ago

can you test with the latest launcher and the latest master-server?

cso2 commented 5 years ago

An error occurs when creating a room with LAN IP in the latest version.

Error: Data buffer is too small at InRoomPacket.readUInt32 (C:\Users\admin\dist\packets\in\packet.js:112:19) at new InRoomNewRequest (C:\Users\admin\dist\packets\in\room\fullrequest.js:25:31) at InRoomPacket.parse (C:\Users\admin\dist\packets\in\room.js:74:35) at new InPacketBase (C:\Users\admin\dist\packets\in\packet.js:21:14) at new InRoomPacket (C:\Users\admin\dist\packets\in\room.js:23:1) at ChannelManager.onRoomRequest (C:\Users\admin\dist\channel\channelmanager.js:74:27) at ServerInstance.onIncomingPacket (C:\Users\admin\dist\serverinstance.js:186:38) at ServerInstance.onSocketData (C:\Users\admin\dist\serverinstance.js:160:14) at Socket.newSocket.on (C:\Users\admin\dist\serverinstance.js:85:18) at emitOne (events.js:116:13)

cso2 commented 5 years ago

If you cancel the game start counter, the server will crash.

Error: Data buffer is too small at InRoomPacket.readUInt8 (C:\Users\admin\dist\packets\in\packet.js:88:19) at new InRoomCountdown (C:\Users\admin\dist\packets\in\room\countdown.js:10:31) at InRoomPacket.parse (C:\Users\admin\dist\packets\in\room.js:89:34) at new InPacketBase (C:\Users\admin\dist\packets\in\packet.js:21:14) at new InRoomPacket (C:\Users\admin\dist\packets\in\room.js:23:1) at ChannelManager.onRoomRequest (C:\Users\admin\dist\channel\channelmanager.js:74:27) at ServerInstance.onIncomingPacket (C:\Users\admin\dist\serverinstance.js:186:38) at ServerInstance.onSocketData (C:\Users\admin\dist\serverinstance.js:160:14) at Socket.newSocket.on (C:\Users\admin\dist\serverinstance.js:85:18) at emitOne (events.js:116:13)

L-Leite commented 5 years ago

@GEEKiDoS I couldn't replicate this on a virtual machine running windows 7, tested with korean and chinese system locales. Is this still happening to you?

HouTom commented 5 years ago

Hello,I can answer you about this question, The master-sever can not know Chinese room name .Please use English or Korean room name.

L-Leite commented 5 years ago

@GEEKiDoS @ChenyuHou can any of you log the packets with the cmd argument --log-packets, then upload them somewhere? You can email them to me, if you don't wish to make the packets public

CarldricGaming commented 5 years ago

packets.zip here is the packets file.

Start with launcher.exe and many weirds cvar.

Can't use cheat cvar cam_snapto in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cam_ideallag in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cam_idealdelta in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cam_idealyaw in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cam_idealpitch in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cam_idealdistright in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_maxpitch in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_minpitch in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_maxyaw in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_minyaw in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_maxdistance in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_mindistance in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_orthowidth in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar c_orthoheight in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cl_upspeed in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cl_forwardspeed in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar cl_backspeed in multiplayer, unless the server has sv_cheats set to 1. exec: couldn't exec valve.rc Can't use cheat cvar fog_startskybox in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar fog_endskybox in multiplayer, unless the server has sv_cheats set to 1. Can't use cheat cvar fog_maxdensityskybox in multiplayer, unless the server has sv_cheats set to 1.`

Try to open with Server before open launcher.

`C:\My Files\Games\Online Games\Counter-Strike Online 2\Server>npm run-script start -- -i 192.168.43.137 -l

cso2-master-server@0.3.0 start C:\My Files\Games\Online Games\Counter-Strike Online 2\Server node dist/server.js "-i" "192.168.43.137" "-l"

PacketDumper: using packets/in/ as incoming dir PacketDumper: using packets/out/ as outgoing dir PacketDumper, cleaning in dir PacketDumper, cleaning out dir holepunch listening at 192.168.43.137:30002 server is now started listening at 192.168.43.137:30001 new client connected 192.168.43.137:53120 uuid: 1136819c-d7cd-44a2-b818-32a720dbb8ea packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 1 length: 37 1136819c-d7cd-44a2-b818-32a720dbb8ea sent a version packet. clientHash: 611e84b30de268f09e5973d2db3884ac (node:1100) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 2 length: 55 trying to login as Test packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 3 length: 2 unknown packet id 72 from 1136819c-d7cd-44a2-b818-32a720dbb8ea packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 4 length: 3 unknown packet id 91 from 1136819c-d7cd-44a2-b818-32a720dbb8ea packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 5 length: 1 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 6 length: 3 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 7 length: 2 unknown packet id 107 from 1136819c-d7cd-44a2-b818-32a720dbb8ea packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 8 length: 77 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 9 length: 23 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 10 length: 14 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 11 length: 11 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 12 length: 14 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 13 length: 11 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 14 length: 14 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 15 length: 11 packet from 1136819c-d7cd-44a2-b818-32a720dbb8ea seq: 16 length: 14`

all game modes workings fine.

CarldricGaming commented 5 years ago

bandicam 2018-12-31 18-04-36-717

L-Leite commented 5 years ago

Does launcher's build 0.1.11 fix this?

CarldricGaming commented 5 years ago

same problems.

Launcher.exe

launcher log (at pastebin)

on Server:

server log (at pastebin)

all game modes workings fine except cvar that. unless the server has sv_cheats set to 1.

My Specs:

CPU: AMD Athlon 64 x2 Dual Core Processor +5000
RAM: 2GB
GPU: NVIDIA Geforce GT 630 (2GB VRAM)
OS: Windows 10 Pro x64
L-Leite commented 5 years ago

@CarldricGaming Those messages are not an issue, they come from CS:S I think

Also, please create a new issue if your problem isn't related to any existing one's

L-Leite commented 5 years ago

Considering @DebugBios managed to create a room (see #19 or #20), I'll assume this is fixed