L-rrrr / pe

0 stars 0 forks source link

duplicate phone number detection when multiple phone number is added #7

Open L-rrrr opened 1 week ago

L-rrrr commented 1 week ago

image.png

Give the design of the product, multiple phone numbers, let's say 3, can be inputted in the phone number field. However, I might have forgotten I have keyed in this person and input the same person but with only 2 duplicate phone numbers. In this case, the app will not detect this as a duplicate.

Suggestion: there should be a detection if a new valid phone number matches a substring of another person's phone number.

nus-se-script commented 1 week ago

Team's Response

Thank you for bringing this up. After further consideration, we believe this issue falls under Planned Enhancement 9, where we have outlined plans to implement duplicate phone number checks in a future iteration. Additionally, implementing substring checks for phone numbers may lead to unintended bugs and complications. Given our current design choices, verifying whether one person's phone number contains another's would be overly complex and impractical.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The following picture clarifies what is considered not in scope on CS2103T website: image.png

The following picture is the duplicate handling specified in UG: image.png