L0laapk3 / FactorioMaps

L0laapk3's FactorioMaps mod
https://mods.factorio.com/mod/L0laapk3_FactorioMaps
Other
118 stars 22 forks source link

Script just freezes after generating images (100+ hour game Space Exploration + Krastorio) #110

Closed DrParanoia closed 9 months ago

DrParanoia commented 1 year ago

So, at some point in my save file the script simply stops after killing Factorio (no error messages, no progress, no nothing).

Tried running it on a virtual Linux machine, it seems that the script does indeed continue past the point it freezes on Windows, but in the end there is some kind of different error which prevents final metadata files to be generated.

Maybe there could be an option to skip the screenshot generation and move to the last part where the metadata is generated? Thanks!

Platform: Windows 11 RAM: 32GB Processor: Ryzen 5800x

MysticMia commented 1 year ago

You might be running into this: KeyError: "There is no item named 'space-exploration-graphics_0.6.13/graphics/icons/alerts/core-seam-icon.png' in the archive" on line 804, "zipInfo = zipObj.getinfo(os.path.join(mod[2], icon + ".png").replace('\', '/'))" Cause I probably have exactly the same issue. I checked in the zip folders. The image file exists and follows nearly the same path. Only the version section of the mod folder seemed different inside the zip file: In zip file: space-exploration-graphics/graphics/icons/alerts/core-seam-icon.png Program: space-exploration-graphics_0.6.13/graphics/icons/alerts/core-seam-icon.png

I checked other issues. It seems linked to #99

DrParanoia commented 1 year ago

@MysticMia Don't think so. It was working fine up until about like 160h mark 😄 Also there are absolutely no errors. I remember having the error you described, and I think I solved it by downloading the mod directly from the dev branch here.

L0laapk3 commented 1 year ago

Sorry for the lack of responses. Were you able to reproduce the crash multiple times or is this a random thing?

As for "the option to skip screeshot generation", there is already something like that --dry, however I can't recommend using it.

The linux problem may be caused by https://github.com/L0laapk3/FactorioMaps/issues/102 .

DrParanoia commented 1 year ago

@L0laapk3 Well it's not a crash :( It just sits there with no messages and no CPU use. Will the --dry option continue the processing though after skipping the screenshot part? I think I've tried it, and it did not.

L0laapk3 commented 1 year ago

If this is something that is happening consistently, it might be worth it for me to try to run it for your savefile & mods folder.

DrParanoia commented 1 year ago

Sure, I tried to find the smallest save out of my backups because otherwise it will take A LOOONG TIME for you to test 😆 https://drive.google.com/file/d/1bybJIJR7e7ivYuK3zsOOdxXv6eMAlIp-/view?usp=share_link

Please note, that it's happening on Windows. Thanks!

L0laapk3 commented 9 months ago

Hey, I tried running this on the latest dev branch on a fresh windows install and it worked without hiccups. I'm going to close this, if there are any further problems feel free to open a new issue :)