search

L0laapk3 / FactorioMaps

L0laapk3's FactorioMaps mod
https://mods.factorio.com/mod/L0laapk3_FactorioMaps
Other
121 stars 22 forks source link

Group nearby tags #22

Open L0laapk3 opened 5 years ago

L0laapk3 commented 5 years ago

Deduplicate tags from different snapshots on the timeline, and group the nearby ones together and maintain a constant spacing between them.

MeeperBeeper commented 4 years ago

Just an idea, but instead of trying to group the tags from the different snapshots, why not have the tags tied to the individual snapshot times. As you change what time you're viewing you change what tags are shown too.

In other words, instead of showing all tags across all times for each individual time, only show the tags that belong to that time. IIRC (I'm not on my home PC at the moment), you already have the tags grouped by time in the json data you save, so why not show the tags for the individual times instead of trying to figure out how to group them with some kind of fuzzy logic about how close they have to be to group together.

This also opens up the possibility of removing the option "no-tag" from the auto.py script altogether. Instead of making the choice at the time of map creation, move the choice of displaying the tags or not to the browser display. This way they can be turned on and off at will long after the map has been generated.

L0laapk3 commented 4 years ago

Thanks for the feedback, if I ever decide to implement this I will keep this into account, however realistically speaking it's unlikely I'll be implementing this anytime soon as I'm quite burned out on factorio at the moment. (Also quite busy)

As a sidenote, I am always open to pull requests :p

MeeperBeeper commented 4 years ago

I can certainly understand that. No guarantees of course but I might be able to help out a little bit here and there (my own time allowing). I'm still pulling your mod apart to find out just exactly how it works though.

L0laapk3 commented 4 years ago

By the way, you're always free to message me on discord for explanation or help if you're stuck on something :)