L0laapk3 / FactorioMaps

L0laapk3's FactorioMaps mod
https://mods.factorio.com/mod/L0laapk3_FactorioMaps
Other
121 stars 22 forks source link

Big Map Processing Not Working (Maybe map Lua?) #24

Closed IIPoliII closed 5 years ago

IIPoliII commented 5 years ago

Hello, I am trying to create a FactorioMaps preview for this actual map : https://factorio-saves.poli.fun/Home/Join-And-Play-Coop-Saves/Old-Saves/06-Feb-12:54.zip

Sadly i the map don't get corped i except 2 things :

Is there any fix for maps like this maybe could you try to fix it by your side ? Thanks Poli ^^

L0laapk3 commented 5 years ago

If you want to increase the screenshotting range have a look at some of the configuration settings: https://github.com/L0laapk3/FactorioMaps/blob/master/README.md

What problems are you experiencing with the "script in the map"? (I assume you are talking about a scenario script?)

IIPoliII commented 5 years ago

Okay i will try for the first one. But yes i mean Scenario because when i ran the "script" at first it did me an error with lua. And never starts the process of making the screenshots. https://i.imgur.com/JrlCnx1.png

L0laapk3 commented 5 years ago

Thats a false error, its a problem with factorio that will be fixed in 0.17. See #15.

If you've interrupted the script before or it had an error, its quite likely that the output folder for that map is in a bricked state and you should --delete it.

If thats not the cause of the problem, one of the things you can try is: if you are running a lot of mods, it might be useful to figure out why things are not working to use the --verbosegame flag. Can you also let me know whats happening to factorio in the meantime, if it gets stuck somewhere?

IIPoliII commented 5 years ago

I will try this once I get home again in a few hours thanks !

IIPoliII commented 5 years ago

Okay i try now but i tried again normally on another PC and got this error like a permission error from factorio so it don't move now. https://i.imgur.com/LK0qOqW.png Same with other maps who worked on python 2. But this time is probably an permission error (god)

IIPoliII commented 5 years ago

The folder seem to have the good permissions it's weird https://i.imgur.com/rMoj2PO.png image

L0laapk3 commented 5 years ago

Can you try deleting the output folder (script-output/JAPC-Feb-06) before running? its likely that a previous crash caused the folder to be in some kind of bricked state now.

IIPoliII commented 5 years ago

yes sure

IIPoliII commented 5 years ago

Well the error is still there it's weird that i don't accept to save their i will try to execute it as admin but it should work

IIPoliII commented 5 years ago

what i found really weird is that he actually is able to create the folders and create them except the script-output one.

L0laapk3 commented 5 years ago

it could also be that your drive is full or something. Also, in this (https://i.imgur.com/rMoj2PO.png) screenshot you are using a different output folder, just to be sure did you try deleting that one before it starts?

IIPoliII commented 5 years ago

Yes but it's the pc's problem i guess i tried again on my laptop all is good. But on the other pc i removed the folders on both outputs but is probably an system error can not be your fault. But i am trying the script again on my laptop for now it's working but i guess it can take up all the night because of the size of the map let's check!

IIPoliII commented 5 years ago

Well big maps seems like it can't be processed even with new settings :/ it stays stuck

L0laapk3 commented 5 years ago

Can you upload the map + zip of mods if any? I'll try it myself then

IIPoliII commented 5 years ago

Sure here is the zip https://factorio-saves.poli.fun/Home/Join-And-Play-Coop-Saves/Old-Saves/06-Feb-12:54.zip

IIPoliII commented 5 years ago

Thanks for your help between!

L0laapk3 commented 5 years ago

I've noticed that your maps just takes ages before it starts doing anything, I've found one bug that gave an error but I haven't seen you report it, other than that it just takes a long time before it starts doing anything, presumably because of the size of the map.

IIPoliII commented 5 years ago

I've noticed that your maps just takes ages before it starts doing anything, I've found one bug that gave an error but I haven't seen you report it, other than that it just takes a long time before it starts doing anything, presumably because of the size of the map.

Oh really? What bug for me i have not any errors on this map. But i am intressted what is it?

L0laapk3 commented 5 years ago

I got that after about 8 minutes of waiting, but don't worry about it too much as I fixed the bug already. I'm now able to generate timelines of your savefile. :D

IIPoliII commented 5 years ago

That's nice to hear and oh damn how did you did the timelines? :o

L0laapk3 commented 5 years ago

I just mixed it with a completely different savefile from me lol

Can you confirm that it infact works now?

IIPoliII commented 5 years ago

Yes it works but sadly on my main pc I got a tiny main ssd do you know if there is an option to change the default temp folder since the map generates me more than 50gb of Printscreen at first ? Thanks ^^

L0laapk3 commented 5 years ago

The temp folder doesnt actually store any significant amount of data. What you can do (what I did) is create a symlink from script-output/FactorioMaps to for example D:/FactorioMaps: on windows this would be (from cmd from in the script-output folder) MKLINK /J FactorioMaps D:/FactorioMaps

IIPoliII commented 5 years ago

Yes I know what you mean but actually I think the symlink don't work as excepted. Factorio actually write at first in the temp folder and it's not really symlinked the error happens at a moment sadly I didn't made a print screen I remember it was an issue https://forums.factorio.com/viewtopic.php?t=6397 for crashes I guess they fixed it by finishing the current-game and then one it's finished move it to the actual script-output folder

L0laapk3 commented 5 years ago

If factorio makes the screenshots to a temp folder before moving them, there shouldnt be more than a handfull of screenshots there at once anyways. Either way, I dont have any idea how to work around that then. Sorry.

L0laapk3 commented 5 years ago

Feel free to reopen or create a new issue if you think there are still bugs.