search

L0laapk3 / FactorioMaps

L0laapk3's FactorioMaps mod
https://mods.factorio.com/mod/L0laapk3_FactorioMaps
Other
119 stars 22 forks source link

syntax error in auto.py #41

Closed skelgaard closed 5 years ago

skelgaard commented 5 years ago

File "auto.py", line 112 print(f"PID: {pid}") ^ SyntaxError: invalid syntax

skelgaard commented 5 years ago

and one more File "auto.py", line 175 print(f'Bad flag: "{key}"')

skelgaard commented 5 years ago

File "auto.py", line 176 raise ValueError(f'Bad flag: "{key}"')

skelgaard commented 5 years ago

seems to be loads of errors File "auto.py", line 396 f'fm.autorun = {{\n'

L0laapk3 commented 5 years ago

Sounds like you are using python 2. Python 3 is required for this mod.

skelgaard commented 5 years ago

python3 -v Python 3.5.3 (default, Sep 27 2018, 17:25:39)

$ python3 auto.py File "auto.py", line 396 f'fm.autorun = {{\n' ^ SyntaxError: invalid syntax

L0laapk3 commented 5 years ago

Whoops, f strings were introduced in python 3.6. I'll update the readme to reflect this. Please update your python :]

skelgaard commented 5 years ago

ok i can only get python 3.5 on my debian machine, and am not going to run testing on a production machine

L0laapk3 commented 5 years ago

If you're commited, you can change all the f strings to normal string concatenations, it should (?) work for you then :)

On Tue, 18 Jun 2019, 11:21 skelgaard, notifications@github.com wrote:

ok i can only get python 3.5 on my debian machine, and am not going to run testing on a production machine

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/L0laapk3/FactorioMaps/issues/41?email_source=notifications&email_token=ABQFLT2W35BYLOZF2LJ5FR3P3CSJFA5CNFSM4HY4K2C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5YGIA#issuecomment-503022368, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQFLTYHX5INU5MVWEALKJDP3CSJFANCNFSM4HY4K2CQ .

skelgaard commented 5 years ago

nah i will wait.. seems there is around 1 month to release of next debian which have 3.7 in it... just a shame.. wanted to test it on my servers, but can't now then

L0laapk3 commented 5 years ago

You will probably encounter one or two problems with platforms other than windows, at the very least #37. I'm trying my best to keep, etc unix compatible but I sometimes mess it up

https://github.com/L0laapk3/FactorioMaps/labels/Linux%2FMac