Fix two bugs in `cbits` relating to distribution values

L0neGamer / ekg-core

Library for tracking system metrics

BSD 3-Clause "New" or "Revised" License

40 stars 39 forks source link

Closed thoughtpolice closed 4 years ago

thoughtpolice commented 4 years ago

The included commit messages have extensive details included, and are independent of each other, but I decided to submit them as a batch.

23Skidoo commented 4 years ago

In more abstract terms, the identity members of the min/max monoids are not zero, but maxBound/minBound!

Can we fix this by setting cMin to maxBound and cMax to minBound in newCDistrib instead?

23Skidoo commented 4 years ago

Answering myself: see this comment by @thoughtpolice.

23Skidoo commented 4 years ago

Merged and released on Hackage.