L0um15 / Spotisharp

Cross-platform music assistant
MIT License
51 stars 11 forks source link

Will work only for playlist with at most 100 tracks #6

Closed cristiMiomni closed 3 years ago

cristiMiomni commented 3 years ago

Describe the bug SpotiSharp will retrieve only first 100 tracks from a playlist which might have more than 100. The reason is Spotify API pagination and I think it should be added (maybe using PaginateAll from SpotifyAPI.Web)

How To Reproduce Any playlist with more than 100 tracks

Desktop (please complete the following information):

L0um15 commented 3 years ago

Definitely i'll have to look into it.

Here is a workaround which can be used until solution is found. In spotify application you can select tracks with ctrl. Just like in any file manager application you can copy and paste them to newly created playlist using keyboard shortcuts. Make 2 temporary playlists and split tracks between them.

L0um15 commented 3 years ago

Added pagination and it seems to work correctly I have to make few checks before releasing it.

obraz

obraz

cristiMiomni commented 3 years ago

Definitely i'll have to look into it.

Here is a workaround which can be used until solution is found. In spotify application you can select tracks with ctrl. Just like in any file manager application you can copy and paste them to newly created playlist using keyboard shortcuts. Make 2 temporary playlists and split tracks between them.

Already did that, thanks for suggestion. I am mostly interested to see how you implemented pagination (I tried myself to do it on your code with with no luck)

L0um15 commented 3 years ago

Here is solution: obraz

L0um15 commented 3 years ago

It won't stop :) obraz

cristiMiomni commented 3 years ago

Thanks a lot

L0um15 commented 3 years ago

I considered this issue as solved. If any issues occurs feel free to re-open this issue. Also don't forget to leave a star if you like SpotiSharp so others can find this repository :) EDIT: SpotiSharp 1.1.3 is available.