search

L13 / vscode-diff

Compare two folders in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=L13RARY.l13-diff
Other
90 stars 10 forks source link

Windows Symbolic Link with path to not existing file ["broken path"] #104

Closed irvnriir closed 1 year ago

irvnriir commented 3 years ago

Such are not copied, i use symbolic links also to target dynamically added data, so i hope you implement this support .

Also, Windows 's Hardlinks are unfolded to the whole files, and Junctions converted to Symbolic Links (i do not see these as issues, but maybe there should be a settings or something else) .

irvnriir commented 3 years ago

And it feels missed : an ability to copy all, with deleting files with exist only in the targeted folder .

Edit: Also, on Copy Selection it doesn't replace items that are of different type, this may be useful, but ability to copy all is missed .

irvnriir commented 3 years ago

And, when l13Diff.abortOnError=false and the subject symlinks present in 2+/{medium+ amount} of items set to be copied, the copy function seem to run infinitely .

L13 commented 3 years ago

Hi, I will check it later this week.

L13 commented 2 years ago

Hi, sorry for the late response. It seems the api does not provide a feature to figure out if it is a hard or a soft link. So I can't fix it.

irvnriir commented 2 years ago

As far i understand hardlinks can't be broken . You mean there is no way to determine whether its a symlink or { file/folder (the only existing hardlink/ MFT item) / hardlink } ?

Is there any way to get any output which lets to know that the file is a broken link ?

Can this help ?

L13 commented 2 years ago

This is maybe possible, but I have to test this first. There are two different stat objects in nodejs. Maybe comparing those two does the job.

irvnriir commented 2 years ago

fs.existsSync fails for such links . the Extension .zip repo, contains Commit #67 which solves the subject (i don't use gulp), but idk whether if (stat) will give false for not existing file .

L13 commented 2 years ago

The development for the extension has been paused until autumn, because there is no time to do something. Stuff like this needs a couple of hours and requires min 2 weeks of testing before I release a new version. Sorry for the bad news.

irvnriir commented 2 years ago

I understand you . Dw . Meanwhile others can download and use the zip .

Other users -- also notice that such copied links are correctly counted by Windows Explorer, unlike such ones initially created by some other programs ; so the WE may show different file counts on actually equal folders .

L13 commented 1 year ago

New release copies now symlinks even if the file in the link does not exist.