search

L13 / vscode-diff

Compare two folders in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=L13RARY.l13-diff
Other
90 stars 10 forks source link

Add whitelist feature #111

Closed big213 closed 1 year ago

big213 commented 2 years ago

This PR attempts to add a file/folder pattern whitelist feature to the extension. Please note that I was unable to compile and test this on my device (due to lots of weird errors that I kept getting when doing npm install), so I have just made the edits that I think will accomplish this. Please test these and see if they are working as expected.

big213 commented 2 years ago

Also, this would resolve #110

L13 commented 2 years ago

Hi. After a first look it seems you have just copied the exclude functions and properties. But this can't work. The first question is how should the include work. Is it just a filter or also a starting point / root folder and works also inside excluded folders? Your version doesn't match one of them.

Right now I have clearly no time do write new features or to test things. Before every release I test new feature minimum 1 - 2 weeks. The development for the extension has paused until autumn. But I can put the idea on my todo list. Sorry for the bad news.

In the mean time you can use the filter in the list view. Just open the search widget with (Ctrl/Cmd + F). It also supports regexp. So you can filter nearly in the same way you can do with includes.

big213 commented 2 years ago

Hi. After a first look it seems you have just copied the exclude functions and properties. But this can't work. The first question is how should the include work. Is it just a filter or also a starting point / root folder and works also inside excluded folders? Your version doesn't match one of them.

Ah yes, that is a fair point. I was thinking maybe to simplify things, it could be one or the other. Either it will check for files/folders to exclude or ones to include, but not both simultaneously. It would check for patterns within the start point folder. There would have to be an option to select which mode you want to use -- exclude or include.

In the mean time you can use the filter in the list view. Just open the search widget with (Ctrl/Cmd + F). It also supports regexp. So you can filter nearly in the same way you can do with includes.

Thanks, I'll check out this feature in the meantime.