search

L13 / vscode-diff

Compare two folders in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=L13RARY.l13-diff
Other
90 stars 10 forks source link

Paths wrapping #68

Closed irvnriir closed 3 years ago

irvnriir commented 3 years ago

Paths of diff-found files/folders wrap for 1360px-wide VSCode window, and are not relative to the actual one . (i usually use 1120px)

L13 commented 3 years ago

Hi, the paths in the list view are not wrapping anymore in the next version. This is an optimization for unlimited files otherwise it will not work.

irvnriir commented 3 years ago

I don't think that the wrapping is more important than unlimited files, but its definitely a meaningful ergonomics feature .

Thanks for answers .

L13 commented 3 years ago

Hi, I have implemented virtual scrolling in the list view. It responses now way faster. So I close the issue because path wrapping would make it too complex. I recommend to use Ctrl/Cmd + B which toggles the sidebar view. I use this command if I need more space in the editor or in the diff panel.

irvnriir commented 3 years ago

@L13 i already open Sidebar only when need it and use "Activitus Bar" Extension . Good to hear it works faster, i guess its about huge amount of differences .?

I've met this : Screenshot

L13 commented 3 years ago

I havn't changed anything in the scan process. It seems l13Diff.abortOnError is true.

Yes, the view only renders now what you see. Before all elements were added to the DOM. That was the reason why it was so laggy with a huge amount of files. But HTML, CSS and JS does not provide anything to solve this problem, so I had to write my own virtual scrolling. The VS Code Team did this for their views, too. So I had to rewrite and test a lot of stuff.

irvnriir commented 3 years ago

other settings didn't change after the update . you keep doing cool things X)