L1L1 / cardpeek

Automatically exported from code.google.com/p/cardpeek
Other
454 stars 117 forks source link

Transport type parsing for Mobib seems to read one extra bit #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Transport type on Mobib in the code is:

metro     0 (00000)
premetro  7 (00111)
bus      15 (01111)
tramway  22 (10110)

On my card I have:
 0 (000000)
31 (011111)
45 (101101)

It would be bus + tramway (which would make sense from what I remember that 
day) if shifted by a bit.

Also:
transport_type = 
mobib_process_block(ref,"EventTransportType",99,104,block,mobib_TRANSPORT)      

mobib_process_block(ref,"EventLocationId",104,120,block,mobib_TRANSPORT_METRO)

It seems the transport type should stop at 103 if metro information starts at 
104

Original issue reported on code.google.com by pterjan on 30 Jun 2013 at 3:41

GoogleCodeExporter commented 9 years ago
Reading up to 103 instead of 104 gives me the bus line and stop I remember 
using that day

Original comment by pterjan on 30 Jun 2013 at 3:42

GoogleCodeExporter commented 9 years ago

Original comment by pterjan on 30 Jun 2013 at 5:12

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks!
I've mainly used the subway in Brussels, so I could have missed this issue.
I'll investigate this more in detail in the next couple of weeks. I'm hoping to 
release cardpeek 0.8 by the end of July... 

Original comment by L...@gmx.com on 2 Jul 2013 at 10:50

GoogleCodeExporter commented 9 years ago
Patch was applied in r425.

Original comment by L...@gmx.com on 6 Jul 2013 at 4:37

GoogleCodeExporter commented 9 years ago
I hope it is fixed now. Closing the issue.

Original comment by L...@gmx.com on 12 Sep 2013 at 11:59