search

L1L1 / cardpeek

Automatically exported from code.google.com/p/cardpeek
Other
454 stars 117 forks source link

Consolidation of forks #87

Closed arseny92 closed 5 years ago

arseny92 commented 7 years ago

Consolidation

Disclaimer: for issues with changes I do not own, please contact the forks in question: use the network view

Questions regarding calypso/c376 go here

ghost commented 5 years ago

Wow, thanks!! @arseny92

arseny92 commented 5 years ago

Hi @arseny92 , How can I try your changes on my cardpeek installation? Can you please provide more info on how to test the changes you've made?

@ybaruchel

Sure. First, install the normal version of Cardpeek. Then apply my changes of dot_cardpeek_dir to your Cardpeek user folder at C:\Users\.cardpeek to use the updated scripts

Note that there are still a few issues with this, as somehow (unsure how) I broke e.g. the showing of the profile/card issuance/expiration dates, and since my Lua skills are mostly voodoo programming, not sure how to fix that and some other things. If anyone proficient with Lua can check, you may submit a pull request to my fork.

tomer8007 commented 5 years ago

I broke e.g. the showing of the profile/card issuance/expiration dates

@arseny92 I had the en1545_DATE fields not showing too, and in my case I could make it work by removing the %a from this line at en1545.lua. Does that work for you maybe?

arseny92 commented 5 years ago

@tomer8007 I figured out why en1545_DATE not working. It only works correctly if the system date format is mm/dd/yyyy (US). The output format is weekday mm/dd/yyyy. It's just that en1545.lua needs to be updated to support other date formats. Nothing to do with the string variable you removed.

tomer8007 commented 5 years ago

review of recent additions to MOT rules is still underway when I'll have some time for this (updates of contract lists, etc.) ;)

@arseny92 Have any idea of where the "030721SDI-NT-DataModel" document is?

arseny92 commented 5 years ago

@tomer8007 That specific document as far as I'm aware is only published by MOT to transit operators and companies that actually need the specification to operate (Pcentra, HopOn etc.). Which means, 99% of the entire c376 script (and ravkav-strings.lua) come from the other files' data, contained in that zip, about how all this is supposed to work, combined with data from transit operators tender agreements (such as this) combined with public information about the upstream CNA standard without the local Israeli differences - such as this. Sometimes even just original research in the form of try/error guesswork produced the right fields parsing...