search

L1NNA / SV1DUR

Planes-On-The-Bus-Go-Swish-Swish-Swish
3 stars 1 forks source link

Word bit corrections #5

Open JBanks opened 2 years ago

JBanks commented 2 years ago

https://github.com/L1NNA/I-NEED-A-NAME/blob/c51d235acbcdaa7a90136d3fff83d2665244ed4c/pkg/src/sys.rs#L73-L74 Mode and subaddresses should cover the same bits.

https://github.com/L1NNA/I-NEED-A-NAME/blob/c51d235acbcdaa7a90136d3fff83d2665244ed4c/pkg/src/sys.rs#L80 "all" should only go to bit 19, which would be the parity bit.

steven-hh-ding commented 2 years ago

yes _all should only to up to 19 (inclusive). I was thinking non-inclusive. For mode code yes it should also be 10-13 in order to set a mode of 31.

steven-hh-ding commented 2 years ago

in #31