search

L1nkZ / rpatchur

A customizable, cross-platform patcher for Ragnarok Online clients.
https://l1nkz.github.io/rpatchur/
Apache License 2.0
50 stars 34 forks source link

Change order of login parameters #22

Closed vstumpf closed 3 years ago

vstumpf commented 3 years ago

Fixes #21

I don't have a real client to test with, but I made a small app to print the args, here's the output:

D:\blah\CLA.exe
-t:asdfa
jkljk
1sak1

Sry am new to rust, if there's a better way let me know.

waken22 commented 3 years ago

Just as reminder, i needed to change this to make SSO login work, because it was sending the "commas" to the emulator, at least it was happening to me, you need to test it :

vstumpf commented 3 years ago

Interesting, the program I tested with did not receive any quotes. It's a c++ program that loops through argv printing each arg on a new line. Later I'll set up a client and try.

waken22 commented 3 years ago

Maybe the problem it's mine, that's why if someone can check it ;p

L1nkZ commented 3 years ago

Thanks for the PR! 😁 I'll try to test this out if you can't, when I find the time.

waken22 commented 3 years ago

In my case if i don't pass the "server" argument the client crash, so... yes i guess it gonna be needed 👍

vstumpf commented 3 years ago

After all the changes, here's a packet dump:

[Debug]: --- 00-01-02-03-04-05-06-07-08-09-0A-0B-0C-0D-0E-0F   0123456789ABCDEF
[Debug]: 000 25 08 64 00 2E 00 00 00 00 6D 79 75 73 65 72 31   %.d......myuser1
[Debug]: 001 00 80 00 00 E3 84 6D 82 AC F0 19 00 9C DC FD 76   .�..�m���..���v
[Debug]: 002 FF FF FF FF A4 F0 19 00 4B DD FD 76 90 3B 06 10   ������..K��v�;..
[Debug]: 003 43 52 65 73 E0 30 22 10 00 00 00 00 41 41 2D 41   CRes�0".....AA-A
[Debug]: 004 41 2D 41 41 2D 41 41 2D 41 41 2D 41 41 31 37 32   A-AA-AA-AA-AA172
[Debug]: 005 2E 32 36 2E 31 34 34 2E 31 00 81 07 50 61 53 73   .26.144.1.�.PaSs
[Debug]: 006 57 6F 52 64                                       WoRd
[Status]: Request for connection of myuser1 (ip: 172.19.0.1)

I'm not sure why the client doesn't strip the quotes. For reference, without removing the quotes,

[Debug]: --- 00-01-02-03-04-05-06-07-08-09-0A-0B-0C-0D-0E-0F   0123456789ABCDEF
[Debug]: 000 25 08 65 00 2E 00 00 00 00 22 75 73 65 72 6E 61   %.e......"userna
[Debug]: 001 6D 65 22 00 40 BF 83 36 AC F0 19 00 9C DC FD 76   me".@��6��..���v
[Debug]: 002 FF FF FF FF A4 F0 19 00 4B DD FD 76 E0 42 CF 16   ������..K��v�B�.
[Debug]: 003 43 52 65 73 E0 D6 20 10 00 00 00 00 45 30 2D 44   CRes�� .....E0-D
[Debug]: 004 35 2D 35 45 2D 36 35 2D 36 44 2D 46 30 31 37 32   5-5E-65-6D-F0172
[Debug]: 005 2E 32 36 2E 31 34 34 2E 31 00 7E 03 50 61 73 57   .26.144.1.~.PasW
[Debug]: 006 6F 72 44 21 22                                    orD!"
L1nkZ commented 3 years ago

Alright, thanks a lot for testing this, I'm merging 👍