search

L2-Technology / sensei

A lightning node implementation for everyone
https://l2.technology/sensei
Other
199 stars 39 forks source link

Add connection node info to response when creating a child node #72

Closed orbitalturtle closed 2 years ago

orbitalturtle commented 2 years ago

Adds connection info in proto response when creating a child node. Closes #70

johncantrell97 commented 2 years ago

thanks!

also need to make sure you update the http api to include this information as well

orbitalturtle commented 2 years ago

@johncantrell97 No problem! Added the node id to the response as well.

Looking to add it to the http api https://github.com/L2-Technology/sensei/blob/68d53e48e0b5e7f40a711b81b15c4375fc323ccd/src/http/admin.rs#L544 But here isn't it just calling the AdminService and grabbing that response, which is already changed in the PR? Or am I missing something?

johncantrell97 commented 2 years ago

@johncantrell97 No problem! Added the node id to the response as well.

Looking to add it to the http api

https://github.com/L2-Technology/sensei/blob/68d53e48e0b5e7f40a711b81b15c4375fc323ccd/src/http/admin.rs#L544

But here isn't it just calling the AdminService and grabbing that response, which is already changed in the PR? Or am I missing something?

oh whoops, you're right. looks good to me!