search

L21s / keycloak-monitoring-prometheus

Monitor your keycloak with prometheus
MIT License
64 stars 17 forks source link

Adding more event data #10

Closed hypery2k closed 5 years ago

hypery2k commented 5 years ago

see #9 still WIP

tobilarscheid commented 5 years ago

Hi Martin,

like your additions! One thing I am wondering about though: What does this change mean to backwards compatibility? My prometheus knowledge is a little rusty right now, but I am guessing where I had just one metric before I would now get multiple ones grouped by for example IP address? Is that correct? Not that this is an issue as such, I would just make sure to correctly bump the new version number then and state the fact in the release notes.

hypery2k commented 5 years ago

the old data won't have the data, but it can be easily grouped, e.g. by event_type

tobilarscheid commented 5 years ago

Hi Martin,

how do we proceed with this? I think if you add documentation to the readme I would be fine to merge this.

Regards,

Tobi

hypery2k commented 5 years ago

sure, just added the README info