confusion around env variable naming. two different?

L21s / keycloak-monitoring-prometheus

Monitor your keycloak with prometheus

MIT License

64 stars 17 forks source link

confusion around env variable naming. two different? #5

Closed devdavidkarlsson closed 6 years ago

devdavidkarlsson commented 6 years ago

KEYCLOAK_PROMETHEUS_EVENTS_DIR in MonitoringEventListenerProviderFactory but it is called EVENTS_DIRECTORY in the Dockerfile in the conditional property setting.

Why is this?

Also: is it supposed to be a relative path, in that case relative to what?

tobilarscheid commented 6 years ago

‘KEYCLOAK_PROMETHEUS_EVENTS_DIR’ is just for the case that you can not influence keycloaks standalone.xml - see https://github.com/larscheid-schmitzhermes/keycloak-monitoring-prometheus#configuring-using-an-environment-variable

‘EVENTS_DIRECTORY’ is only valid in the scope of the sample dockerfile and has no meaning outside of it.

Relative path: no, always absolute!