search

L3-N0X / obsidian-marker

Configure a marker api endpoint and use it to convert your pdfs into markdowns with best ocr, embedded tables, images and every other benefit of marker!
MIT License
27 stars 1 forks source link

Datalab API not supported #2

Closed jerme42 closed 3 months ago

jerme42 commented 3 months ago

Very sorry if I am a dummy. I really don't know what I am doing. I am trying to configure the endpoint in the settings. I'm using the data lab api but it doesn't connect. I checked that the service is working fine. How do I properly format the endpoint in the settings page on obsidian?

L3-N0X commented 3 months ago

Oh, I'm sorry, I totally forgot about the point, that the datalab api doesn't have the same endpoints and functionality as the selfhosted solution. So, the datalab api wasn't even supported until now. I made an update to the plugin (v1.2.0), could you please test if this is working for you now? You only have to set your API Endpoint to "Datalab" and insert your API Key and check if the conversions work. I even added support for docx and pptx files when converting with datalab api. (I don't use this api myself and I can't test it right now)

jerme42 commented 3 months ago

nice! As soon as obsidian publishes the update I will give it a test.

L3-N0X commented 3 months ago

Thanks for testing! 1.2.0 is now published correctly, so you can try and see if it works

jerme42 commented 3 months ago

No probs. And thanks for the plugin!

I get an error when trying to convert. here is the console log (if its helpful):

Error during PDF conversion: Error: Request failed, status 400 at new t (app.js:1:2030716) at vK (app.js:1:2030908) at app.js:1:2031587 at app.js:1:237138 at Object.next (app.js:1:237243) at a (app.js:1:235961)

L3-N0X commented 3 months ago

Thanks for testing! I updated the plugin again, this should probably fix this error. If not, message me again!

jerme42 commented 3 months ago

Error.

plugin:marker-api:309 Error during PDF conversion: Error: Request failed, status 422 at new t (app.js:1:2030716) at vK (app.js:1:2030908) at app.js:1:2031587 at app.js:1:237138 at Object.next (app.js:1:237243) at a (app.js:1:235961)

L3-N0X commented 3 months ago

This was way more complicated than I thought, but I used the same approach now for the self hosted version, and there It works. So I'm very confident now that it will work also for the datalab endpoint. Please test again with version 1.2.2 if this finally fixes the issue.

jerme42 commented 3 months ago

connection test works. error on conversion. Maybe I'm doing something wrong here. Error during PDF conversion: Error: Request failed, status 422 at new t (app.js:1:2030716) at vK (app.js:1:2030908) at app.js:1:2031587 at app.js:1:237138 at Object.next (app.js:1:237243) at a (app.js:1:235961)

L3-N0X commented 3 months ago

Now it should really work, version 1.2.3 and if not, I still added more debugging messages so we can find the problem. But I think I already found the problem, now no 422 error comes up anymore, the request is now formatted correctly.

jerme42 commented 3 months ago

Good news: no connection error. Bad news: no markdown file. Here is the console log after trying a few different pdfs. I tried them manually with a crappy py script and they work with the api so it isn't on that end I think.

plugin:marker-api:317 Error in convertWithDatalab: TypeError: data is not iterable at Marker.processConversionResult (plugin:marker-api:459:29) at eval (plugin:marker-api:299:28) eval @ plugin:marker-api:317 plugin:marker-api:318 Uncaught (in promise) Error: Error in convertWithDatalab: TypeError: data is not iterable at eval (plugin:marker-api:318:21) plugin:marker-api:317 Error in convertWithDatalab: TypeError: data is not iterable at Marker.processConversionResult (plugin:marker-api:459:29) at eval (plugin:marker-api:299:28) eval @ plugin:marker-api:317 plugin:marker-api:318 Uncaught (in promise) Error: Error in convertWithDatalab: TypeError: data is not iterable at eval (plugin:marker-api:318:21) plugin:marker-api:317 Error in convertWithDatalab: TypeError: data is not iterable at Marker.processConversionResult (plugin:marker-api:459:29) at eval (plugin:marker-api:299:28) eval @ plugin:marker-api:317 plugin:marker-api:318 Uncaught (in promise) Error: Error in convertWithDatalab: TypeError: data is not iterable at eval (plugin:marker-api:318:21)

L3-N0X commented 3 months ago

Okay, the error should now be fixed in 1.2.4, datalab once again differs from marker-api and doesn't return data the same way.

jerme42 commented 3 months ago

the md is created but empty. Thanks for working on this!

L3-N0X commented 3 months ago

Sorry, this update took a bit longer, but now I had the time to look into it once again. Can you please test it again? I also added more logging to the function getting the results after starting the request in case it still doesn't work

jerme42 commented 3 months ago

solved. well done. chapeau.

L3-N0X commented 3 months ago

Okay, great! Thank you so much again for testing!