search

L3-N0X / spicetify-dj-info

Display BPM, Key and more next to each Song!
MIT License
33 stars 3 forks source link

make css important in case theme or snippet overwrites #19

Closed webcubed closed 3 months ago

L3-N0X commented 3 months ago

Thanks for the PR! Does this fix anything with the comfy theme (#17 or #18)? Or is this just 'in case' there will be overwrites?

webcubed commented 3 months ago

I'm not sure, still testing. It theoretically should work but for now, it looks like this just makes the css not apply 😭 image it's supposed to fix this, should've tested before opening pr.

webcubed commented 3 months ago

image this monstrosity

webcubed commented 3 months ago

happens because other themes overwrite the grid template image

webcubed commented 3 months ago

adding !important works but my implementation seems to be breaking it.

webcubed commented 3 months ago

image Alright i think it's good

webcubed commented 3 months ago

Thanks for the PR! Does this fix anything with the comfy theme (#17 or #18)? Or is this just 'in case' there will be overwrites?

This was tested on the comfy theme and it will apply "in case", so it should fix the problem entirely

webcubed commented 3 months ago

This existing css might/will conflict with the extension that shows the playlists that a certain song is in image but only when not fullscreened

L3-N0X commented 3 months ago

Yeah just tested it too, works like a charm! I was wondering if it may even be possible to just "add" a column and keeping the default formatting because the left spacing is not the same with comfy UI now because the whole css gets replaced with the css in this code, replacing any changes made by themes. But I guess this is not too important, so i'll be merging this! The conflict with other extensions is a known problem, it sometimes gets fixed when zooming out, but I can't gurantee that this extension works together fine with every other extension out there