search

L3tum / HardwareInformation

.NET Standard Cross-Platform Hardware Information Gatherer
MIT License
56 stars 11 forks source link

Access modifiers to setters, C# 9.0 #22

Closed caunt closed 3 years ago

caunt commented 4 years ago

Want to contribute :)

Setters now just internals, no need to give access to users. IReadOnlyList used instead of normal List access Language version changed to 9.0 for beautiful OSPlatform enumeration 😄

L3tum commented 3 years ago

LGTM 👍 There's a few minor things like spaces and what not but I'll fix that post-merge. Thank you! 😄

caunt commented 3 years ago

I am sorry for spaces not in your codestyle 😕

That was Visual Studio extension CodeMaid that formats every single file when it's saved.

I noticed that too late but next time I'll disable it 😄