search

L4ki / Magna-Plasma-Themes

Magna Themes For Plasma Desktop
GNU General Public License v3.0
25 stars 2 forks source link

Set image fill mode to preserve aspect ratio. #1

Closed meowtochondria closed 10 months ago

meowtochondria commented 10 months ago

Change the fill mode so that image is not squished on displays that are not exactly the aspect ratio of images/background.png

L4ki commented 10 months ago

Hi meowtochondria,

I updated the file Splash.qml

I added: fillMode: Image.PreserveAspectCrop

I think it's fine now.

Thank you very much.

meowtochondria commented 10 months ago

Thank you for including the change.

I'd recommend including the same change in other places as well. For example, I found the same issue happening with Colorful-Splash.

Not sure if you are new to Github, but generally people hit the 'Merge' button on PR if they agree with the change. This way, the project shows participation from other people as well, which might be good in the long run.

I'm closing the PR for now as the intended change has been made.