L5-Z / pe

0 stars 0 forks source link

Favourites does not differentiate between the types of favourites #7

Open L5-Z opened 7 months ago

L5-Z commented 7 months ago

The favourites list does not differentiate the type of activity. Unless it is used in personalisation such as in smart (if so, it is not mentioned in the userguide), it makes the whole point of entering in a location, cuisine and price pointless. You won't be able to differentiate between a food or activity and neither do they show the type of cuisine, price or location:

____________________________________________________________
food chikin, E, C, J
Cupid's arrow strikes! This is now in your favourites.
chikin
You've collected 2 romantic treasures!
____________________________________________________________
favourites
Drumroll, please! Presenting the stars of your romantic sky:
1. run
2. chikin
____________________________________________________________
activity swim, E, C
Cupid's arrow strikes! This is now in your favourites.
swim
You've collected 3 romantic treasures!
____________________________________________________________
favourites
Drumroll, please! Presenting the stars of your romantic sky:
1. run
2. chikin
3. swim
____________________________________________________________
nus-se-script commented 7 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Favourites does not specify Location and Price

The favourites list does not print the location nor price of the activity. Unless it is used in personalisation such as in smart (if so, it is not mentioned in the userguide), it makes the whole point of entering in a location and price pointless:

____________________________________________________________
favourites
Drumroll, please! Presenting the stars of your romantic sky:
1. run
____________________________________________________________

[original: nus-cs2113-AY2324S2/pe-interim#2265] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for raising up this issue! To address some of your concerns:

1. Issue: "favourites list does not print the location nor price of the activity" Given that users are responsible for the description of the activity when inputting 'favourites', we believe that the responsibility is on the user to ensure that there is enough distinction to understand what their favourited activity is.

Citing the example you gave, if the user decided to favourite their activity as 'run', it implies that the user simply enjoys running, and thus data such as the location of the activity is redundant due to the very broad nature of the activity 'run'. We believe that it is a fair assumption to assume that for a meaningful 'favourite' entry, users would be more specific and personal, such as entering 'run at East Coast Park'. In this case, the location and price of the activity can be inferred from the description itself.

While we acknowledge that moving forward, displaying the location and price point would provide some clarity to the users, we believe that this issue is of lower priority than the basic functionality that the team was trying to achieve in v2.1

2. Issue: "it makes the whole point of entering in a location and price pointless"
The purpose of asking users to include a location and price when inputting 'favourites' as well is that not only is the activity updated in the 'Favourites' database, but it is updated in the 'ActivityList' database as well. While the 'location' and 'price' currently serve little function within the 'favourites' command, these inputs are necessary to be included in the 'ActivityList' database, as they will be used to filter out the relevant activities during generation of idea or itinerary

Screenshot 2024-04-22 120423.png

Screenshot 2024-04-22 120449.png

However, we believe that your feedback is valid to be used in improvements for future iterations and hence, will mark it as NotInScope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** No details provided by team.