LA1TV / Hyperdeck-JS-Lib

A javascript library for communication with the Blackmagic Hyperdeck.
MIT License
26 stars 8 forks source link

Command: [commands] output is not as expected, parsing error #36

Closed shinsuny closed 6 years ago

shinsuny commented 6 years ago

1 2

shinsuny commented 6 years ago

[params] does not contain XML string object

joshhodgson commented 6 years ago

According to the manual, [commands] is the only command in the protocol which doesn't comply with the response syntax below

{Response code} {Response text}:
{Parameter}: {Value}
{Parameter}: {Value}
...

The practical benefit of being able to return the XML seems somewhat limited to me, given the detail in the manual. If you want to do a PR though, it will be merged!

shinsuny commented 6 years ago

It will save time of debugging for others.

joshhodgson commented 6 years ago

This is true. I'll reopen and eventually sort something if nobody beats me to it!

shinsuny commented 6 years ago

Thanks !!

Up next, https://github.com/LA1TV/Hyperdeck-JS-Lib/issues/38