LA1TV / Hyperdeck-JS-Lib

A javascript library for communication with the Blackmagic Hyperdeck.
MIT License
26 stars 8 forks source link

Command: [ format: prepare:{format} ] output is not as expected, parsing miss #41

Closed shinsuny closed 6 years ago

shinsuny commented 6 years ago

similar to

36

38

※ format token is not parsed so can not use [ format: confirm:{token} ]

tjenkinson commented 6 years ago

Hey @sarveshwar-singh I can't find the response structure for this command in the documentation. Please can you provide the response to 'format: prepare'? Is it XML again?

joshhodgson commented 6 years ago

IIRC it's just a string which is the "password" to format the disk

On 30 Sep 2017 2:11 pm, "Tom Jenkinson" notifications@github.com wrote:

Hey @sarveshwar-singh https://github.com/sarveshwar-singh I can't find the response structure for this command in the documentation. Please can you provide the response to 'format: prepare'? Is it XML again?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LA1TV/Hyperdeck-JS-Lib/issues/41#issuecomment-333307594, or mute the thread https://github.com/notifications/unsubscribe-auth/AHQSGsGDEUuw3lAjMqdyzQEjzf-PtA28ks5snj3tgaJpZM4PoMYG .

shinsuny commented 6 years ago

image

Response = "216 format ready xxxxxx

" xxxxxx = string of length 6

※Sorry for being late to reply. :(

tjenkinson commented 6 years ago

Thanks!

There's no colon so my other pr still won't work. Will update later. What kind of protocol is this!

shinsuny commented 6 years ago

Thanks !!

As per my understanding format is 2 step process.

  1. Preparation => [ format: prepare: exFAT/HFS+ ] => {token}
  2. Actual Format => [ format: confirm: {token} ]
joshhodgson commented 6 years ago

"It's always param: value except where it's not and that's a lot"

tjenkinson commented 6 years ago

Yep we should be able to add a function for this command in hyperdeck.js which will handle the verification automatically too

tjenkinson commented 6 years ago

@sarveshwar-singh I just updated https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/42 which also now has a format() method. Please could you give it a try?

shinsuny commented 6 years ago

Due to working environment restrictions i am not able to test it, but it look good in code. :)

tjenkinson commented 6 years ago

great I just released a new version