search

LA1TV / Hyperdeck-JS-Lib

A javascript library for communication with the Blackmagic Hyperdeck.
MIT License
26 stars 8 forks source link

Update slots. #55

Closed benjaminkay93 closed 6 years ago

benjaminkay93 commented 6 years ago

Updating the if sttement on the slots... finally

joshhodgson commented 6 years ago

Please remove the "to-do" if you've done it 😛

joshhodgson commented 6 years ago

I think the thought behind it was to either ask for "slot info" or "slot info: slot id" but you're probably right, the ID can be served as-is if it's there

benjaminkay93 commented 6 years ago

ill remove the todo, but the unions have told me i have to give a 2 year lead time on completing this work.

tjenkinson commented 6 years ago

Yeh I think

if (typeof id ==='number')

Is probably enough

joshhodgson commented 6 years ago

String would work too as long as it's "1" or "2"

On Wed, 18 Apr 2018, 18:13 Tom Jenkinson, notifications@github.com wrote:

Yeh I think

if (typeof id ==='number')

Is probably enough

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/55#issuecomment-382461424, or mute the thread https://github.com/notifications/unsubscribe-auth/AHQSGvqu4pOjz4_tWYT0x-LZ5FxG0y4Iks5tp3RRgaJpZM4TZ2gI .

benjaminkay93 commented 6 years ago

removed the todo, is it worth changing it to number or just leaving it as is for now :P

tjenkinson commented 6 years ago

I think it makes sense to allow any number

tjenkinson commented 6 years ago

closes https://github.com/LA1TV/Hyperdeck-JS-Lib/issues/13 🎉