LA1TV / Hyperdeck-Node-Controller

A hyperdeck controller for control over a web interface to fully utilise the hyperdeck API
6 stars 1 forks source link

Remove the 'net' dependency #9

Closed tjenkinson closed 8 years ago

tjenkinson commented 8 years ago

It doesn't look like a good idea https://github.com/sleeplessinc/net

joshhodgson commented 8 years ago

oh wow yes, I see what you mean

joshhodgson commented 8 years ago

https://nodejs.org/api/net.html looks like 'net' is actually a built in package and initial testing seems to work without that package being installed through npm

joshhodgson commented 8 years ago

...initial testing being

> Error: connect ETIMEDOUT 192.168.72.60:9993
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1063:14)
tjenkinson commented 8 years ago

Yeh its built in that just put all its properties onto the global for some reason

On 23 Mar 2016, at 21:21, Josh Hodgson notifications@github.com wrote:

...initial testing being `hyperdeck.isConnected() false

Error: connect ETIMEDOUT 192.168.72.60:9993 at Object.exports._errnoException (util.js:874:11) at exports._exceptionWithHostPort (util.js:897:20) at TCPConnectWrap.afterConnect as oncomplete `

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

joshhodgson commented 8 years ago

OH I never looked at the code. Don't understand why you'd do that

tjenkinson commented 8 years ago

Me neither!

On 23 Mar 2016, at 21:25, Josh Hodgson notifications@github.com wrote:

OH I never looked at the code. Don't understand why you'd do that

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

joshhodgson commented 8 years ago

Fixing in #10

tjenkinson commented 8 years ago

Cool in 10 you can put

Fixes #9 and it should automatically link and close this ;)

joshhodgson commented 8 years ago

GitHub is cleverer than I...