LA1TV / Roses-CasparCG-Graphics

Location of CG assets for use during the Roses event
6 stars 8 forks source link

separate install and startup, and stop using nodemon #48

Closed joshhodgson closed 7 years ago

joshhodgson commented 7 years ago

unless nodemon is installed globally (npm install -g nodemon), it can't be called from the command line like that on neither windows nor linux

tjenkinson commented 7 years ago

I think a better way would be using an npm script, because then the PATH should be updated correctly to find the binary.

e.g

"scripts": {
   "start":"nodemon server.js"
}

And then it would be started with npm run start (or npm start).

tjenkinson commented 7 years ago

Also we should probably change from using * to at least specifying the current major version

joshhodgson commented 7 years ago

I'll change it to npm start then, good idea

joshhodgson commented 7 years ago

....do we really need nodemon?

tjenkinson commented 7 years ago

¯_(ツ)_/¯ probably not really. Might make sense for dev though? There could be a 'dev' script that runs that and 'start' which just uses node.

npm start actually defaults to node server.js.

joshhodgson commented 7 years ago

We can always change it later, so it makes no difference to the user starting it