Added ability to edit text in a lowerthird

[DomBelcher]

Adds a button to toggle editing in lower thirds

Turns heading and subheading into text fields where they can be edited.

Saves having to delete and redo them all the time

[benjaminkay93]

i was 50/50 with this, but it doesnt edit whats live on screen, however it feels a bit hit and miss with the edit button (am i just being daft?)

[benjaminkay93]

not editing live on screen was my only concern :P

[DomBelcher]

To edit the text live on screen I think you would need to keep track of what was showing to resend the show socket message, could be added in but a bit more complex. Can always just hit show again to change the text on screen

[benjaminkay93]

nooo live on screen edit is a bad thing aha,

[benjaminkay93]

the way it works rn is great, just the edit button seems abit ropy :P

[mstratford]

I like the feature, it's something that would have been useful in various (mostly non Roses specific) use cases. I'm also seeing the edit button only working sporadically.

Since you must click the green buttons to send the changes live, maybe something like changing the text of the green button to signify, "Update Left" or something could be done? The fact that the edit icon does not change (ie to a floppy "save" icon etc) seems like it could be better? :)

Somewhat off-topic, but it might be nice to disable/hide the ability to send the same lower third to multiple screen locations at a time?

[DomBelcher]

There's a few little style changes still to do in my mind, namely:

• change the edit button to a save button when in edit mode
• add some styling to the text boxes - maybe make the heading one bigger than the subheading

Other than those I think the feature works, I think other changes should be looked at in a separate pull request

[stephenrob]

Are you happy to make those minor style changes in this one before i review @DomBelcher ? I agree looking at the other changes separately.

[DomBelcher]

@stephenrob Yeah that's fine, I'll do them when I get the chance

[DomBelcher]

@benjaminkay93 you mean if the edit inputs are empty, as opposed to the create ones?

[benjaminkay93]

Asin to stop that @DomBelcher :)

[DomBelcher]

@benjaminkay93 I can just make it so it prevents creating new lower thirds that are empty, and also editing them to be empty? Preventing creating empty ones isn't strictly related to the edit feature but seems very minor to open a separate PR for

[benjaminkay93]

those words are the words I was looking to say :P makes sense todo that if you can 👍

[DomBelcher]

Also, should it force having a heading, or is just a subheading acceptable?

[benjaminkay93]

I would say heading is required, sub heading is optional looking at how that displays :P

[DomBelcher]

All changes should be addressed as of https://github.com/LA1TV/Roses-CasparCG-Graphics/pull/98/commits/2a89b3e42852fdb64ca299e1c305d93beb3b4793